Re: [Utopia] gnome-volume-manager 1.3.2+ and hal > 0.5.2

[Jeffrey Stedfast <fejj novell com>]

On Mon, 2005-08-08 at 01:18 -0500, Steev wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I have been having problems recently with gnome-volume-manager refusing
> to automount devices, and I was getting a wierd error (a few others were
> getting it as well)
> 
> ** (gnome-volume-manager:20248): WARNING **: manager.c/1590: mount_all
> no device for udi=/org/freedesktop/Hal/devices/volume_uuid_1C98_52D7: (null)
> 
> So, I got to digging into the code, and for some reason, I decided to
> focus on 1590 (at the time, in current cvs, its around 1688)
> 
> I found that this patch applies cleanly, and also, seems to fix the
> problem, however, I am still not sure if the problem is
> gnome-volume-manager or if it is hal not returning proper values.
> 
> diff -urN gnome-volume-manager-1.3.4.orig/src/manager.c
> gnome-volume-manager-1.3.4/src/manager.c
> - --- gnome-volume-manager-1.3.4.orig/src/manager.c       2005-08-08
> 00:46:36.000000000 -0500
> +++ gnome-volume-manager-1.3.4/src/manager.c    2005-08-08
> 00:46:50.000000000 -0500
> @@ -1660,7 +1660,7 @@
>                         continue;
> 
>                 /* mount the device */
> - -               if (!(dev = libhal_device_get_property_string (ctx, udi,
> "block.device", &error))) {
> +               if (dev = libhal_device_get_property_string (ctx, udi,
> "block.device", &error)) {
>                         dbg ("mount_all: mounting %s\n", dev);
>                         gvm_device_mount (udi, dev, NULL);
>                         libhal_free_string (dev);
> 
> 
> this works for usb hard drives, and I guess I would have to go through
> all the code and remove the (! ... )  from each line, but that seems to
> be a bit of overkill.  So, does anyone have any idea?

it's only the 1 line and it's already fixed in CVS anyway...

> 
> I am posting this to both hal and utopia lists, although I am not
> subscribed to hal's list, so it might bounce back.  If it doesn't,
> please CC me from the hal list.
> 
> Thanks for your time.
> 
> - --
> Steev Klimaszewski
> steev steev net
> www.steev.net
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2 (GNU/Linux)
> 
> iD8DBQFC9vlP1c+EtXTHkJcRAhOYAJ9pWwmMfG9/qus2VGcqnHSi1NQueQCeNvmL
> ArijqBMaCVPPagSdhsNj/Ec=
> =fCmq
> -----END PGP SIGNATURE-----
> _______________________________________________
> utopia-list mailing list
> utopia-list gnome org
> http://mail.gnome.org/mailman/listinfo/utopia-list
> 
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com