Re: [Utopia] gnome-vfs HAL patch, take 3

[David Zeuthen <david fubar dk>]

On Fri, Jul 09, 2004 at 11:20:47AM +0200, Kay Sievers wrote:
> On Thu, 2004-07-08 at 23:45 +0200, David Zeuthen wrote:
> >  http://freedesktop.org/~david/gnome-vfs-take3-1.png
> > 
> > 
> > 
> > This screenshot shows another configuration with Firewire disks and a
> > USB based Card Reader for Compact Flash. It also shows all of the icons
> > mentioned
> > 
> >  http://freedesktop.org/~david/gnome-vfs-take3-2.png
> 
> Cool, looks great. Nice job, David.
> 

Thanks!

> > +	/* bail out if fstype is swap */
> > +	if (hal_vol->fstype != NULL && strcmp (hal_vol->fstype, "swap") == 0)
> > +		goto out;
> > +
> 
> Hmm, what about the other unmountable volume types, like the
> mac_partition_map, ...? Shouldn't we add a attribute to HAL like
> 'not_mountable' or just set 'is_mounted = -1', or something similar, so
> HAL gets the control over the browser list and there is no need to
> update the blacklist in gnome-vfs?

Yeah, we should do this in HAL instead (and make it possible to
override it in .fdi files etc.). I haven't got my self an iPod yet but
I believe we want to hide the first of the two partitions as this
contains firmware?

Cheers,
David