Re: [Usability] Escape Closing Dialog

[Federico Mena Quintero <federico ximian com>]

On Tue, 2005-12-13 at 05:04 -0500, Simon Francis wrote:
> Dialogs pop up all the time, and sometimes pressing escape closes
> them, but other times it doesn't. It seems almost at random which
> dialogs escape closes predictably and makes it really hard to navigate
> things with the keyboard. Why is this?

I agree with you.

References:

The GTK+ part: http://bugzilla.gnome.org/show_bug.cgi?id=101293
The HIG part: http://bugzilla.gnome.org/show_bug.cgi?id=124902

Mailing list discussion:
http://mail.gnome.org/archives/gtk-devel-list/2003-December/msg00065.html

For the record, the GTK+ package in Novell and Suse Linux has a patch to
make all dialogs close when you press Escape.  Our users truly love it;
it is said to have increased shareholder value by 0.42%.

I may commit this patch to GTK+ again soon and see if anyone notices or
cares.

  Federico

--- gtk+/gtk/gtkdialog.c~	2005-01-20 13:52:15.000000000 -0600
+++ gtk+/gtk/gtkdialog.c	2005-03-18 11:26:44.000000000 -0600
@@ -420,9 +420,6 @@
   GtkWidget *widget = GTK_WIDGET (dialog);
   GdkEvent *event;
 
-  if (!dialog_find_button (dialog, GTK_RESPONSE_CANCEL))
-    return;
-
   event = gdk_event_new (GDK_DELETE);
   
   event->any.window = g_object_ref (widget->window);