RE: Major speed hacks / unread status

Hi Philip, 

>-----Original Message-----
>From: tinymail-devel-list-bounces gnome org 
>[mailto:tinymail-devel-list-bounces gnome org] On Behalf Of 
>ext Philip Van Hoof
>Sent: Monday, May 29, 2006 11:23
>To: Binnema Dirk-Jan (Nokia-M/Helsinki)
>Cc: tinymail-devel-list gnome org
>Subject: RE: Major speed hacks
>On Mon, 2006-05-29 at 10:39 +0300, Dirk-Jan Binnema nokia com wrote:
>> Maybe some further, micro optimizations:
>> - G_UNLIKELY for the first 'if' might actually make sense here?
>>    or move it to the end of the function. Even better, the 
>>    caller should check and not invoke this function if cur == nth
>> - The third 'if ( )' can  be left out.
>Indeed, a cmp is faster than a jmp. So I shouldn't call the 
>function if I don't have to. I changed it a little bit.

Ah I see... now you could just leave out the last else -- but of course
only for cosmetical reasons.

Something else: I never seem to get back anything but 0 in 
TNY_ACCOUNT_TREE_MODEL_UNREAD_COLUMN. Is that to be expected? And does
this UNREAD correspond to TNY_MSG_HEADER_FLAG_SEEN? Or is it another
(some mailers like mutt differentiate SEEN and UNREAD) - Evo doesn't
to do so.

Best wishes,

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]