Re: iterator patch



On Fri, 2006-07-07 at 16:48 +0300, Dirk-Jan C. Binnema wrote:

> Instead of complaining, here 's a patch making the iterators a bit
> easier to use. I've tried to keep the changes minimal, mostly because
> I'm lazy :-) Therefore, I've just added the '_is_done' method to
> all iterators, which makes writing loops using iterators much nicer.

Right on!

> I've done some testing, and it seems to work... please have a look.

It's committed. Maybe we should get you an account on the
Subversion? ;). Feel free to mail/msg me a username and msg me a
password (over Jabber or over IRC)

> Can I assume that when I create an iterator, it will point at the first
> element at the start?

Yes. Maybe we or I should document that somewhere in the interface
description and make a unit test for it?

If somebody feels brave, go ahead. It's definitely something that needs
a unit test at some point.


-- 
Philip Van Hoof, software developer at x-tend 
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
work: vanhoof at x-tend dot be 
http://www.pvanhoof.be - http://www.x-tend.be




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]