Re: [Bug] in tny_account_store_add_account()

[Philip Van Hoof <spam pvanhoof be>]

Applied. thanks

On Tue, 2006-08-29 at 15:29 +0200, Thomas Hisch wrote:
> hello tny hackers,
> 
> i think i have found a bug.
> 
> g_conf_get_int already returns the index for the new account (=number of 
> old accounts) so increment count after account specific data was set.
> 
> Index: trunk/libtinymail-gnome-desktop/tny-account-store.c
> ===================================================================
> --- trunk/libtinymail-gnome-desktop/tny-account-store.c	(Revision 816)
> +++ trunk/libtinymail-gnome-desktop/tny-account-store.c	(Arbeitskopie)
> @@ -533,8 +533,6 @@
>   	gchar *key = NULL;
>   	gint count = gconf_client_get_int (priv->client, "/apps/tinymail/accounts/count", NULL);
> 
> -	count++;
> -
>   	key = g_strdup_printf ("/apps/tinymail/accounts/%d/hostname", count);
>   	gconf_client_set_string (priv->client, (const gchar*) key,
>   		tny_account_iface_get_hostname (account), NULL);
> @@ -554,6 +552,8 @@
>   		tny_account_iface_get_user (account), NULL);
>   	g_free (key);
> 
> +	count++;
> +
>   	gconf_client_set_int (priv->client, "/apps/tinymail/accounts/count",
>   		count, NULL);
> 
> 
> thi
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, software developer at x-tend 
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
work: vanhoof at x-tend dot be 
http://www.pvanhoof.be - http://www.x-tend.be