[Setup-tool-hackers] GNOME CVS: gnome-system-tools carlosg



CVSROOT:	/cvs/gnome
Module name:	gnome-system-tools
Changes by:	carlosg	02/09/22 17:12:17

Modified files:
	src/time/e-map : ChangeLog Makefile.am e-map.c 

Log message:
2002-09-22  Carlos Garnacho Parro <garnacho@tuxerver.net>

* Makefile.am: fixed to create marshallers before trying to use them

* e-map.c: fixed to use created marshaller

URL : http://cvs.gnome.org/bonsai/cvsquery.cgi?module=gnome-system-tools&branch=HEAD&branchtype=match&dir=gnome-system-tools&file=&filetype=match&who=carlosg&whotype=match&sortby=Date&hours=&date=explicit&mindate=09%2F22%2F02+17%3A11&maxdate=09%2F22%2F02+17%3A13&cvsroot=%2Fcvs%2Fgnome


What was the reason of that commit? 

Makefile.am was done by suggested (http://developer.gnome.org/dotplan/porting/ar01s15.html)
way, it worked before that commit also:

[tambet@router e-map]$ make
( /home/tambet/gnome2/bin/glib-genmarshal --prefix=e_map_marshal e-map-marshal.list --header > e-map-marshal.tmp \
&& mv e-map-marshal.tmp e-map-marshal.h ) \
|| ( rm -f e-map-marshal.tmp && exit 1 )
source='e-map.c' object='libemap_a-e-map.o' libtool=no \
depfile='.deps/libemap_a-e-map.Po' tmpdepfile='.deps/libemap_a-e-map.TPo' \
depmode=gcc3 /bin/sh ../../../depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I../../..   -DMAP_DIR=\""/home/tambet/gnome2/share/
<snip>

e-map.c:

[tambet@router e-map]$ cvs diff -u -r 1.23 -r 1.24
cvs server: Diffing .
Index: e-map.c
===================================================================
RCS file: /cvs/gnome/gnome-system-tools/src/time/e-map/e-map.c,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- e-map.c	18 Sep 2002 12:50:04 -0000	1.23
+++ e-map.c	22 Sep 2002 21:12:16 -0000	1.24
@@ -200,7 +200,7 @@
 			      G_SIGNAL_RUN_LAST,
 			      G_STRUCT_OFFSET (EMapClass, set_scroll_adjustments),
 			      NULL, NULL,
-			      e_map_marshal_VOID__OBJECT_OBJECT,
+			      g_cclosure_user_marshal_VOID__OBJECT_OBJECT,
 			      G_TYPE_NONE, 2,
 			      GTK_TYPE_ADJUSTMENT, GTK_TYPE_ADJUSTMENT);
 /*	


Why did you have to rename that closure? Does it look better now?


There are TONS of bugs to fix, why waste time on some questionable non-important my-way-is-the-best-way
things?
--
Tambet Ingo <tambet@ximian.com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]