Re: [Rhythmbox-devel] patch for the lyrics plugin

[Gareth Murphy <garethmurphy1 eircom net>]

Actually, loading the lyrics every time the song is changed IS
undesirable behaviour. Because the fact is that it's a waste of
bandwidth and resources to lookup the lyrics every time a song is
changed, when the fact is that people don't tend to want to look at the
lyrics of many songs they listen to.

The ways a lyrics display plugin should fit into the user interface are
varied and need to be discussed further, but I think the majority of the
devs will agree with me that we definitely SHOULDN'T search for lyrics
on every song change... rather we should only retrieve them at the users
request.

Regards,
Gareth

on Mon, 2006-05-22 at 10:28 +0300, ÐÐÐÑÐÑ ÐÐÐÑÑÐÑÐÐ wrote:
> Firstly, I can't think of a single reason why someone would want to look
> at the lyrics, without listening to the song. If you have some please
> share. Now that that's out of the system, people that want that can
> easily click on the desired song, bring it's properties, and look at the
> lyrics there. The two displays are totally independent. For the rest of
> us, I think that changing the lyrics with the song is a good thing (tm).
> 
> p.s. Here's a second patch (It includes the first). It changes the title
> of the window to the current song. There's a bug when first showing the
> lyrics window, the lyrics don't get shown (only the "Searching for ..."
> part). They start changing when that current song changes. Perhaps
> someone that actually knows python can fix that.
> 
> Ð ÐÐ, 2006-05-22 Ð 10:26 +1000, Jonathan Matthew ÐÐÐÐÑÐ:
> > On Sun, May 21, 2006 at 12:21:22AM +0300, ÐÐÐÑÐÑ ÐÐÐÑÑÐÑÐÐ wrote:
> > > this small patch makes the plugin search for new lyrics on song change.
> > > I simply copied the code from the coverart plugin. Also, since I don't
> > > know a thing about python or it's syntax, there's a posibility that i've
> > > introduced a bug or two. Seems to work here though.
> > 
> > I'm not sure this is a good idea.  If the user requests the lyrics for
> > one song, it doesn't mean they necessarily want the lyrics for the next
> > one.  If we automatically get the lyrics for the next song, there's no
> > easy way to go back.  If we don't, the user can just use View->Song
> > Lyrics again.
> > 
> > _______________________________________________
> > rhythmbox-devel mailing list
> > rhythmbox-devel gnome org
> > http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel gnome org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel