Re: [Rhythmbox-devel] ANN: RhythmboxLIRC -- a program to control Rhythmbox with a remote control

[Jonathan Matthew <jonathan kaolin hn org>]

On Sat, Sep 10, 2005 at 09:15:08AM +0200, Fredrik Noring wrote:
> Hi,
> 
> Attached is the Lirc patch for Rhythmbox 0.9.0:
> 
>  configure.ac            |   24 ++++++
>  shell/rb-remote.c       |   10 +-
>  shell/rb-remote.h       |    4 -
>  shell/rb-shell-player.c |  106 ++++++++++++++++++++++++++++
>  4 files changed, 136 insertions(+), 8 deletions(-)

There are a few things that bother me about this patch, and the LIRC
code in general, so I fixed them.  With my patch
(http://j.kaolin.hn.org/rhythmbox/rb-lirc.diff) , LIRC support is self
contained, so this might be helpful as a use case for a plugin system or
whatever.

 configure.ac             |   28 ++++-
 shell/rb-remote.c        |  235 +++++++++++++++++++++++++++--------------------
 shell/rb-remote.h        |   20 ----
 shell/rb-shell-player.c  |    6 -
 shell/rb-shell.c         |   15 +++
 shell/rb-source-header.c |    1 
 6 files changed, 173 insertions(+), 132 deletions(-)

-jonathan