Re: [Rhythmbox-devel] music sharing patch #3

[Charles Schmidt <cschmidt2 emich edu>]

On Tue, 2005-08-23 at 17:38 +0100, Peter Robinson wrote:
> > > > Issues/Known Bugs:
> > > > * Signed errors when compiling.  According to walters (i think), gcc 4.0
> > > > added the signed checking thing.  I havn't found time to find packages
> > > > for 4.0 for my system yet, or I'd try to fix this myself.  Until then, I
> > > > suggest writing me a patch or turning off the extra warning checking.
> > >
> > > I think James had a patch.
> > 
> > I've attached a patch which lets it compile with a gcc that complains
> > about signedness - and unlike my last attempt this one just inserts
> > casts, so shouldn't break anything.
> 
> Gets to here in the compile process and drops dead.
> 
> gcc -I/usr/X11R6/include -Wcomment -Wformat -Wnonnull -Wimplicit-int
> -Wimplicit -Wmain -Wmissing-braces -Wparentheses -Wsequence-point
> -Wreturn-type -Wswitch -Wtrigraphs -Wunused-function -Wunused-label
> -Wunused-value -Wchar-subscripts -Wmissing-declarations
> -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align
> -Werror -std=gnu89 -o rhythmbox main.o rb-shell.o rb-shell-player.o
> rb-source-header.o rb-statusbar.o rb-shell-preferences.o
> rb-shell-clipboard.o rb-playlist-manager.o rb-history.o
> rb-play-order.o rb-play-order-linear.o rb-play-order-linear-loop.o
> rb-play-order-shuffle.o rb-play-order-random.o
> rb-play-order-random-equal-weights.o rb-play-order-random-by-age.o
> rb-play-order-random-by-age-and-rating.o
> rb-play-order-random-by-rating.o rb-remote.o rb-tray-icon.o
> -Wl,--export-dynamic -pthread -Wl,--export-dynamic -pthread
> -Wl,--export-dynamic  ../sources/.libs/libsources.a -L/usr/X11R6/lib
> ../sources/.libs/libsourcesimpl.a ../rhythmdb/.libs/librhythmdb.a
> ../iradio/.libs/librbiradio.a ../player/.libs/librbplayer.a
> ../metadata/.libs/librbmetadata.a ../widgets/.libs/librbwidgets.a
> ../lib/.libs/librb.a ../remote/bonobo/.libs/librbbonobo.a -lgnomeui-2
> -lSM -lICE -lbonoboui-2 -lgnomecanvas-2 -lgnome-2 /usr/lib/libpopt.so
> -lart_lgpl_2 -lpangoft2-1.0 -lglade-2.0 -ltotem-plparser -lgnomevfs-2
> -ldbus-glib-1 -lhal -ldbus-1 -lgstcontrol-0.8 -lgstgconf-0.8
> -lgstreamer-0.8 -lgconf-2 -lxml2 -lpthread -lz -lbonobo-2
> -lbonobo-activation -lORBit-2 -lgthread-2.0
> ../remote/.libs/librbremote.a -lnautilus-burn -lgtk-x11-2.0
> -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangoxft-1.0
> -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
> rb-shell.o(.data+0xc): undefined reference to `rb_daap_sources_init'
> rb-shell.o(.data+0x1e4): undefined reference to `rb_daap_sources_shutdown'
> ../player/.libs/librbplayer.a(rb-player-gst.o)(.text+0xeee): In
> function `rb_player_open':
> /usr/src/redhat/BUILD/rhythmbox-0.9.0/player/rb-player-gst.c:531:
> undefined reference to `rb_daap_source_find_for_uri'
> ../player/.libs/librbplayer.a(rb-player-gst.o)(.text+0xf05):/usr/src/redhat/BUILD/rhythmbox-0.9.0/player/rb-player-gst.c:532:
> undefined reference to `rb_daap_source_get_headers'
> ../player/.libs/librbplayer.a(rb-player-gst.o)(.text+0x1884): In
> function `rb_player_set_time':
> /usr/src/redhat/BUILD/rhythmbox-0.9.0/player/rb-player-gst.c:723:
> undefined reference to `rb_daap_source_find_for_uri'
> ../player/.libs/librbplayer.a(rb-player-gst.o)(.text+0x189c):/usr/src/redhat/BUILD/rhythmbox-0.9.0/player/rb-player-gst.c:724:
> undefined reference to `rb_daap_source_get_headers'
> collect2: ld returned 1 exit status
> make[3]: *** [rhythmbox] Error 1
> make[3]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.9.0/shell'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.9.0/shell'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.9.0'
> make: *** [all] Error 2
> 
> Pete

Make sure you've re-run ./autogen.sh.  James said he noticed this as
well, but that a newly checked out copy of CVS with my patch worked just
fine.  I dunno.  Stupid autoconf.

-charlie