Re: [Rhythmbox-devel] music sharing patch #2

[Peter Robinson <pbrobinson gmail com>]

> I've got another music sharing patch for everyone to play with.
> 
> Lots of reorganization & changes from the first one, including the much
> desired ability to share your music via RB.
> 
> The patch is /everything/ against CVS (not split into 'core' & 'daap'
> parts like last time), mostly because I don't have the time to split it
> and test the patches - I'm going out of town tonight and won't be back
> til next Sunday.  I felt it'd be good to get this out there and get some
> feedback as it is.
> 
> As before, you'll still need the patch at
> http://bugzilla.gnome.org/show_bug.cgi?id=312114 against gst-plugins.
> 
> You'll need libsoup to browse shares, and libsoup & howl to publish your
> own share (and the development headers/libraries probably, since you'll
> be compiling this yourself).
> 
> Like I said, I'll be out of town til next Sunday, I hope to have a few
> bug reports/suggestions when I return.

Well after upgrading totem and all the various other requirements I
attempted to compile it on Fedora Core 4 and ran into a couple of
problems.

The first problem was due to me trying to compile it as an rpm package
(sometimes the rpm packages give errors that wouldn't normally fail on
a standard build - this was the case here). I think the problem is
connected to the following snipets from running ./autogen.sh

Running autoheader...
Running automake-1.7...
cp: cannot stat `INSTALL': No such file or directory
configure.ac: installing `./install-sh'
configure.ac: installing `./missing'
Makefile.am: installing `./INSTALL'
daapsharing/Makefile.am: installing `./depcomp'
cmp: INSTALL.autogen_bak: No such file or directory
cp: cannot stat `INSTALL.autogen_bak': No such file or directory
Running ./configure --enable-maintainer-mode ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk

then....

checking whether gcc understands -Wcast-align... yes
checking whether gcc understands -Werror... yes
checking whether gcc understands -std=gnu89... yes
configure: error: conditional "USE_DAAP_BROWSE" was never defined.
Usually this means the macro was only invoked conditionally.

The second problem (when trying to compile it not through my rpm build
system) was due I think to FC4 using gcc 4 which is stricter when it
comes to some things. Output below.

 gcc -DHAVE_CONFIG_H -I. -I. -I..
-DGNOMELOCALEDIR=\"/usr/local/share/locale\"
-DG_LOG_DOMAIN=\"Rhythmbox\" -I.. -I../lib -I../lib -I../corba
-I../corba -I../rhythmdb -I../widgets -I../library -I../player
-I../iradio -I../shell -I../daapsharing
-DPIXMAP_DIR=\"/usr/local/share/pixmaps\"
-DSHARE_DIR=\"/usr/local/share/rhythmbox\"
-DDATADIR=\"/usr/local/share\" -g -O2 -DXTHREADS -D_REENTRANT
-DXUSE_MTSAFE_API -DORBIT2=1 -pthread -I/usr/include/gtk-2.0
-I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0
-I/usr/include/pango-1.0 -I/usr/include/freetype2
-I/usr/include/freetype2/config -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0
-I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0
-I/usr/include/libart-2.0 -I/usr/include/gconf/2
-I/usr/include/libbonoboui-2.0 -I/usr/include/orbit-2.0
-I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0
-I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0
-I/usr/include/libxml2 -I/usr/include/libglade-2.0
-I/usr/include/gnome-vfs-module-2.0 -I/usr/include/totem/1/plparser
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -pthread -DORBIT2=1
-I/usr/include/gstreamer-0.8 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libxml2
-I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -DXTHREADS
-D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/libnautilus-burn
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include
-I/usr/include/atk-1.0 -I/usr/include/pango-1.0
-I/usr/include/freetype2 -I/usr/include/freetype2/config
-I/usr/include/libsoup-2.2 -I/usr/include/libxml2
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/X11R6/include -Wcomment -Wformat -Wnonnull -Wimplicit-int
-Wimplicit -Wmain -Wmissing-braces -Wparentheses -Wsequence-point
-Wreturn-type -Wswitch -Wtrigraphs -Wunused-function -Wunused-label
-Wunused-value -Wchar-subscripts -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align
-Werror -std=gnu89 -MT rb-daap-connection.lo -MD -MP -MF
.deps/rb-daap-connection.Tpo -c rb-daap-connection.c  -fPIC -DPIC -o
.libs/rb-daap-connection.o
cc1: warnings being treated as errors
rb-daap-connection.c: In function 'GenerateStatic_42':
rb-daap-connection.c:323: warning: pointer targets in initialization
differ in signedness
rb-daap-connection.c:334: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:336: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:339: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:341: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:344: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:346: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:349: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:351: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:354: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:356: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:359: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:361: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:364: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:366: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:369: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:371: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:374: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Final' differ in signedness
rb-daap-connection.c:375: warning: pointer targets in passing argument
1 of 'DigestToString' differ in signedness
rb-daap-connection.c:375: warning: pointer targets in passing argument
2 of 'DigestToString' differ in signedness
rb-daap-connection.c: In function 'GenerateStatic_45':
rb-daap-connection.c:383: warning: pointer targets in initialization
differ in signedness
rb-daap-connection.c:394: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:396: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:399: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:401: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:404: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:406: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:409: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:411: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:414: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:416: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:419: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:421: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:424: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:426: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:429: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:431: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:435: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Final' differ in signedness
rb-daap-connection.c:436: warning: pointer targets in passing argument
1 of 'DigestToString' differ in signedness
rb-daap-connection.c:436: warning: pointer targets in passing argument
2 of 'DigestToString' differ in signedness
rb-daap-connection.c: In function 'rb_daap_hash_generate':
rb-daap-connection.c:462: warning: pointer targets in passing argument
1 of 'strlen' differ in signedness
rb-daap-connection.c:463: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:465: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:471: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Update' differ in signedness
rb-daap-connection.c:474: warning: pointer targets in passing argument
2 of 'OpenDaap_MD5Final' differ in signedness
rb-daap-connection.c:475: warning: pointer targets in passing argument
1 of 'DigestToString' differ in signedness
rb-daap-connection.c:475: warning: pointer targets in passing argument
2 of 'DigestToString' differ in signedness
rb-daap-connection.c: In function 'build_message':
rb-daap-connection.c:534: warning: pointer targets in passing argument
2 of 'rb_daap_hash_generate' differ in signedness
rb-daap-connection.c:534: warning: pointer targets in passing argument
4 of 'rb_daap_hash_generate' differ in signedness
rb-daap-connection.c: In function 'rb_daap_connection_get_headers':
rb-daap-connection.c:1006: warning: pointer targets in passing
argument 2 of 'rb_daap_hash_generate' differ in signedness
rb-daap-connection.c:1006: warning: pointer targets in passing
argument 4 of 'rb_daap_hash_generate' differ in signedness
make[2]: *** [rb-daap-connection.lo] Error 1
make[2]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.8.99/sources'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.8.99'
make: *** [all] Error 2
[peterr localhost rhythmbox-0.8.99]$

Cheers,
Pete