On Tue, 2005-04-26 at 07:15 +1000, Jonathan Matthew wrote: > On Mon, Apr 25, 2005 at 03:18:25PM +0200, Oliver Lemke wrote: > > > @jonathan: Please apply the attached patch to your queue branch. > > Applied. Hmm, I wonder how that ever worked before.. Yes, it's indeed strange. BTW, there's one other crasher but I'm not sure how to solve it in a clean way. When opening rhythmbox and the library is loaded, it takes some time before the queue appears in the left pane. If you double click on a song during this short period, rb segfaults because the queue playlist is not yet initialized at this point. Adding a g_return_if_fail (playa->priv->queue_source != NULL); to rb_shell_player_entry_activated_cb in rb-shell-player.c fixes the crash. But somehow it doesn't feel right to do it there because it's not really the root of the problem. What do you think? -- so long, oliver Public GPG Key: http://www.core-dump.info/olemke-public.asc Fingerprint: 2389 0B2C 1AA8 4E3E D5AD 3B72 00DB ABDC 73ED C558
Attachment:
signature.asc
Description: This is a digitally signed message part