Re: [Rhythmbox-devel] comments on the CD Burning in Rhythmbox

[Bastien Nocera <hadess hadess net>]

On Thu, 2004-09-23 at 15:44 +0200, Baptiste Mille-Mathias wrote:
> Hello,
> 
> I've just tested the CD tool in Rhythmbox, it's really a good piece of
> work : clean, not bloatware, and I can list n the audio CD on my CD
> player without a glitch.
> 
> I just have some comments/request to share.

Most of those should be in bugzilla, not here.

> - The burning dialog show all the CD drives, not only the burner. Is
> it possible to only show the CD Recorder ? (I know that kind of code
> was pushed recently on nautilus-cd-burner).

2 lines. patch attached.

---
Bastien Nocera <hadess hadess net> 

Index: configure.ac
===================================================================
RCS file: /cvs/gnome/rhythmbox/configure.ac,v
retrieving revision 1.131
diff -u -r1.131 configure.ac
--- configure.ac	16 Sep 2004 19:16:29 -0000	1.131
+++ configure.ac	23 Sep 2004 15:40:56 -0000
@@ -61,7 +61,7 @@
 		  libglade-2.0                  \
 		  gnome-vfs-2.0 >= 2.6          \
 		  gnome-vfs-module-2.0          \
-		  libnautilus-burn >= 2.7	\
+		  libnautilus-burn >= 2.8.3	\
 		  $USE_HAL)
 
 RHYTHMBOX_CFLAGS="$CFLAGS $RHYTHMBOX_CFLAGS"
Index: sources/rb-playlist-source-recorder.c
===================================================================
RCS file: /cvs/gnome/rhythmbox/sources/rb-playlist-source-recorder.c,v
retrieving revision 1.3
diff -u -r1.3 rb-playlist-source-recorder.c
--- sources/rb-playlist-source-recorder.c	16 Sep 2004 19:16:40 -0000	1.3
+++ sources/rb-playlist-source-recorder.c	23 Sep 2004 15:40:58 -0000
@@ -182,7 +182,7 @@
 
         widget = bacon_cd_selection_new ();
         g_object_set (widget, "file-image", FALSE, NULL);
-        /*g_object_set (widget, "show-recorders-only", TRUE, NULL);*/
+        g_object_set (widget, "show-recorders-only", TRUE, NULL);
 
 	value = eel_gconf_get_string (CONF_STATE_BURN_DEVICE);
         if (value) {