Re: [Rhythmbox-devel] Dashboard integration



On Fri, 2003-12-19 at 05:04, Lee Willis wrote:
> I've updated the patches for rhythmbox/dashboard integration under
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=117083
> 
> to address Colin's previous comments. Unfortunately I can't re-add the
> PATCH keyword to it, can you take a look Colin?

Cool.  Copying my reply from bugzilla here:

Ok, this has been merged into rhythmbox--mainline--0.6--patch-378, and
rhythmbox--mainline--0.7--patch-91.  

I changed -D_GNU_SOURCE to -D_BSD_SOURCE.  _GNU_SOURCE pulls in a lot of
GNU-specific stuff that unfortunately we can't depend on.  _BSD_SOURCE
should be relatively portable.  

I also renamed "rb-dashboard.c" to just "dashboard.c", since it's not
really our source.  I also added an arch-tag.

Otherwise, looks good.  I haven't been able to test it, so if you could
just confirm it works, that'd be good.  Thanks!

This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]