Re: [Rhythmbox-devel] [patch] devel rpm package

[Colin Walters <walters verbum org>]

On Thu, 2003-08-14 at 19:40, Alex wrote:
> This patch splits off the header, the pkgconfig file, and some docs to a
> devel rpm package.

I don't like this patch.  First of all, you moved around Rhythmbox.h,
and not Rhythmbox.idl, which is the critical component.
In fact, Rhythmbox.h should not be installed at all as a system header;
for example, it is not useful for applications which use other ORBs.

Secondly, I just don't feel that there's a lot of gain by splitting off
such a tiny package.

Anyways though, these are just my off-the-cuff opinions; I do not
personally have strong feelings about the .spec file included in rb. 
Christian Schaller wrote it originally, and hopefully he will be
interested in continuing to maintain it, and will be able to comment on
your patch.  If not, William McCann was the last person to modify it,
and perhaps he would be willing to maintain it.

(Christian, William: I have re-attached Alex's patch for your
convenience)

Index: rhythmbox.spec.in
===================================================================
RCS file: /cvs/gnome/rhythmbox/rhythmbox.spec.in,v
retrieving revision 1.9
diff -u -r1.9 rhythmbox.spec.in
--- rhythmbox.spec.in	13 Aug 2003 17:53:16 -0000	1.9
+++ rhythmbox.spec.in	14 Aug 2003 23:33:43 -0000
@@ -28,6 +28,15 @@
 Music Management application with support for ripping audio-cd's,
 playback of Ogg Vorbis and Mp3 and burning of cdroms
 
+%package devel
+Summary:	Headers and and other files used to build things against rhythmbox
+Group:		Applications/Multimedia
+Requires:	%{name}-${version}-%{release}
+Requires:	gtk2-devel >= %{gtk2_version}
+
+%description devel
+Headers and and other files used to build things against rhythmbox
+
 %prep
 %setup -q
 
@@ -56,7 +65,7 @@
 
 %files -f %name.lang
 %defattr(-, root, root)
-%doc AUTHORS COPYING ChangeLog INSTALL README NEWS
+%doc AUTHORS COPYING ChangeLog INSTALL MAINTAINERS README NEWS
 %{_bindir}/rhythmbox
 %{_sysconfdir}/gconf/schemas/rhythmbox.schemas
 %{_datadir}/rhythmbox/*
@@ -68,12 +77,18 @@
 %{_datadir}/idl/Rhythmbox.idl
 %{_libdir}/bonobo/librb-nautilus-context-menu.*
 %{_libdir}/bonobo/servers/*
-%{_libdir}/pkgconfig/*
-%{_includedir}/Rhythmbox.h
 #%{_datadir}/gnome/help/rhythmbox/C/*
 #%{_datadir}/omf/rhythmbox/rhythmbox-C.omf
 
+%files devel
+%doc INTERNALS DOCUMENTERS
+%{_libdir}/pkgconfig/*
+%{_includedir}/Rhythmbox.h
+
 %changelog
+* Thu Aug 14 2003 Alex Converse
+- Split off devel package
+
 * Wed Aug 13 2003 William Jon McCann <mccann@jhu.edu>
 - Updated dependencies and files