Re: [Rhythmbox-devel] id3-vfs changes

[Bastien Nocera <hadess hadess net>]

On Tue, 2003-08-05 at 00:38, Colin Walters wrote:
> On Mon, 2003-08-04 at 18:04, Bastien Nocera wrote:
> > Hey,
> > 
> > Colin, this change:
> > 2003-08-03  Colin Walters  <walters@rhythmbox.org>
> >  
> >         * monkey-media/stream-info-impl/id3-vfs/id3-vfs.c:
> > (search_tags):
> >         Try not to lose completely if we have an ID3v1 tag, and reading
> > an ID3v2 tag fails.
> > 
> > was made in the wrong place. The id3-vfs.c code was a direct port of the
> > id3-file stuff in libid3tag. I think it would be a better idea to fix it
> > around in the mp3 stream-info impl.
> 
> I don't see how to fix it in mp3-stream-info-impl.c, but if you do, feel
> free :)

I didn't see the exact content of your change, and I didn't see that it
had been butchered already, never mind :)

-- 
Bastien Nocera <hadess@hadess.net>