Re: [PATCH] for gnome-session

[Rodrigo Moya <rodrigo novell com>]

On Fri, 2006-03-10 at 11:28 -0700, Elijah Newren wrote:
> On 3/10/06, Rodrigo Moya <rodrigo novell com> wrote:
> > Hi
> >
> > Attached patch makes gnome-session use a single GConfClient instead of being getting/unreffing
> > it every time it's needed.
> >
> > This is safe code-wise and makes startup improve a little bit more, apart from fixing a couple
> > of leaks (initialize_ice and set_sessionsave_mode). It's been approved
> > already by Vincent Untz on IRC.
> 
> Indeed the patch does look perfectly safe from looking over it; but
> I'm still really afraid of non-critical changes so soon before the
> release.  Could you try to get a bunch of testers to run with it for a
> day?  I'll test it too and then let's look at it tomorrow (unless, of
> course, you get the necessary approvals from others first...)
> 
some novell developers (included me) have been running with it for a few
days now, with no problems at all.
-- 
Rodrigo Moya <rodrigo novell com>