Re: [PATCH] for bad re-enterancy problem on slow machines

[Rodrigo Moya <rodrigo novell com>]

On Tue, 2006-03-07 at 09:36 -0500, Luis Villa wrote:
> On 3/7/06, michael meeks <michael meeks novell com> wrote:
> >
> > On Tue, 2006-03-07 at 08:56 -0500, Luis Villa wrote:
> > > This makes me very nervous, given the timing, but clearly it is a bad
> > > problem, so we should probably commit it. Is there someone else (maybe
> > > Mark?) who is familiar with Bonobo and can double/triple-check the
> > > code just to be certain?
> >
> >         So - wrt. the code change they are somewhat banal - of course, the
> > debugging session behind that is more involved ;-)
> >
> >         basically just:
> >
> > +       char *copy = g_strdup (original);
> >         ...
> > -       foo (original);
> > +       foo (copy);
> > +       g_free (copy);
> >
> >         for 2 separate methods.
> >
> >         hard to see how it could go that wrong & it fixes some really nasty
> > login behavior on those old/slow machines we're encouraging people to
> > use by telling them how much faster the next release is :-)
> 
> The path was 4K, so it seemed a bit bigger than that. Go ahead
> (assuming one other A-OK); if we could get a new tarball ASAP so
> Fedora, Ubuntu, OpenSuse, etc. can package and ship and test ASAP that
> would be great.
> 
as soon as approved, I can make a release.
-- 
Rodrigo Moya <rodrigo novell com>