Re: Approval for small change in gnome-vfs' http neon method

[Frederic Crozat <fcrozat mandriva com>]

Le jeudi 31 août 2006 à 12:09 -0600, Elijah Newren a écrit :
> On 8/31/06, Christian Kellner <gicmo gnome org> wrote:
> > Hey release team,
> >
> > Matthias spotted a nasty little bug in http neon method which gets
> > triggered if the number of maximum (http) redirects is reached. In a few
> > places we try to translate the neon result code into a GnomeVFSResult
> > _after a call to http_follow_redirect_ which will hit an assertion. We
> > of course shouldn't be trying to resolve the neon result code but
> > instead just return the GnomeVFSResult we got from http_follow_redirect
> > in case of an error. The little patch[1] of mine does that. It only
> > changes a few places which are touched when redirects happen and its
> > nothing complicated but its a "crash" (g_assert_not_reached) so I would
> > rather get rid of it! The bugzilla.gnome.org bug is 353337[2].
> 
> Well, since it's crashing already, it probably can't get much worse,
> and Matthias has tested as well, so here's 1 of 2.

Approval 2 of 2.

-- 
Frederic Crozat <fcrozat mandriva com>
Mandriva