(Another) Hard code freeze for Yelp



Hi,

Hot on the heels of the last request for a freeze break comes another
request (for a hard-code freeze break in yelp).

Bug #353567 [1].  This is caused by a freeing an object that shouldn't
be freed when a file is bzip2 compressed.  The fix (attached as a patch)
simply removes the freeing instance and allows the bzip library to
handle it.

Again, this doesn't affect translations or docs, but is a fairly
critical bug as it stops any documentation in bzip format being read.

Don

[1] http://bugzilla.gnome.org/show_bug.cgi?id=353567
Index: src/yelp-io-channel.c
===================================================================
RCS file: /cvs/gnome/yelp/src/yelp-io-channel.c,v
retrieving revision 1.11
diff -u -r1.11 yelp-io-channel.c
--- src/yelp-io-channel.c	28 Aug 2006 19:42:54 -0000	1.11
+++ src/yelp-io-channel.c	30 Aug 2006 16:54:15 -0000
@@ -171,11 +171,6 @@
 {
     YelpIOChannel *yelp_channel = (YelpIOChannel *) channel;
 
-#ifdef HAVE_LIBBZ2
-    if (yelp_channel->bzin)
-	g_free (yelp_channel->bzin);
-#endif
-
     g_free (yelp_channel);
 }
 
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/yelp/ChangeLog,v
retrieving revision 1.914
diff -u -r1.914 ChangeLog
--- ChangeLog	30 Aug 2006 12:32:33 -0000	1.914
+++ ChangeLog	30 Aug 2006 16:54:20 -0000
@@ -1,3 +1,8 @@
+2006-08-30  Don Scorgie  <don Madaline>
+
+	* src/yelp-io-channel.c: 
+	Don't double free bzip streams
+	
 2006-08-30  Don Scorgie  <dscorgie cvs gnome org>
 
 	* src/yelp-search-pager.c: 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]