Re: GNOME 2.16 freeze break requested for two Orca bugs...

[Willie Walker <William Walker Sun COM>]

Thank you for the approval!  Thanks also for the nitpick (I applied the
nitpick suggestion) - it shows that you actually reviewed the
patch.  :-)

Will

On Wed, 2006-08-30 at 10:48 +0200, Vincent Untz wrote:
> Hi,
> 
> Le mercredi 30 ao�06, �0:50, Kjartan Maraas a �it :
> > tir, 29,.08.2006 kl. 17.32 -0400, skrev Willie Walker:
> > > Hi All:
> > > 
> > > Many apologies for this freeze break request.  I was up late last night
> > > tracking down problems in other modules and ended up not getting to
> > > these in time for the code freeze.  :-( I'm requesting to be able to
> > > apply the following patches to the Orca module for GNOME 2.16.  There
> > > are no associated string changes with either patch:
> > > 
> > > http://bugzilla.gnome.org/show_bug.cgi?id=353467: When launched from a
> > > GUI menu or other launcher, text-based setup cannot be accessed
> > > 
> > > The impact of this bug is that the user will be very very confused when
> > > they launch Orca from a GUI mechanism (e.g., the "Run Application"
> > > dialog or a launch menu) and Orca falls into text-setup mode.  The
> > > resolution is to spawn a gnome-terminal and launch orca from within it
> > > when appropriate.  We've already seen a number of questions regarding
> > > this on the ubuntu-accessibility mailing list, so it's a high visibility
> > > problem.
> > > 
> > This sounds good to me, but someone else will have to vouch for the code
> > doing what the description says :-)
> 
> I've added a small comment to the bug that you can ignore (minor
> nitpick).
> 
> Let's say that Kjartan approved this, so approval 2 of 2 :-)
> 
> > > http://bugzilla.gnome.org/show_bug.cgi?id=353476: Orca does not fallback
> > > properly to a working synthesis engine
> > > 
> > > The impact of this is that an ill-behaved gnome-speech driver, or one
> > > that is installed without its associated speech engine(s) in place, can
> > > cause Orca to be speechless when it is started.  This is not good and is
> > > also very confusing and difficult for users to debug.  The resolution is
> > > to attempt to fallback to a working gnome-speech synthesis driver and
> > > use it if one exists.
> > > 
> > I'm ok with this one too with the same caveat as above.
> 
> Looks fine to me => approval 2 of 2.
> 
> (This brings an interesting question for the release team: approving
> code freeze will be harder with more languages in the desktop suite. Eg:
> I'm not sure I'd be able to approve a code freeze for some C# code, and
> a few months ago, I wouldn't have been able to approve a code freeze for
> python code... How can we make this easier for us?)
> 
> Vincent
>