Breaking freeze for bug-buddy

[Olav Vitters <olav bkor dhs org>]

Hello Release Team,

This is a request to break freeze to add a password field to Bug-Buddy
interface. Although this seems like a simple addition, it will have a
big impact. I'm sure I can do the server side on time, however the
Bug-Buddy changes are big, so there is a potential for new bugs.

The relevant bug is 351489 – allows people to send bugs using another's
email address -- http://bugzilla.gnome.org/show_bug.cgi?id=351489

There is no patch for this yet, plus Fer's computer died. He has a new
one now, but unsure when he has time. To fix this I need to backport a
patch from upstream Bugzilla to bugzilla.gnome.org. After that bug-buddy
needs to change.

Older Bug-Buddy versions had the same problem, except with the new UI it
is far more obvious that you can fill in whatever email address you like.

Thoughts?


Basically what need to be done is:
1. Backport a account token creation patch from Bugzilla to GNOME
Bugzilla (almost done)
2. Change Bug importing to check password, optionally send token emails
3. Change Bug-Buddy to have a password field (breaking UI+string freeze)
4. Add some extra strings to deal with new error codes

How I imagine this to work is:
a) User exists on bugzilla.gnome.org
1. Application crashes
2. User enters email address + password
3. Send via XML-RPC and bug is created

b) User does NOT exist on bugzilla.gnome.org
1. Application crashes
2. User enters email address + password
3a. Send via XML-RPC.. gives error message back that account does not
    exist.
3b. Server sends account creation token.
4. Because of the error message, Bug-Buddy stores the bug submission
locally and informs user to start bug-buddy later when account is
created  <---- NOT SURE ABOUT THIS!!!

However, we need to account for the following as well
a) User exists on bugzilla.gnome.org, but password is incorrect
1. Application crashes
2. User enters email address + password
3. Send via XML-RPC
4. Server notices password is incorrect and sends back error message
5. Bug-Buddy notifies user (string freeze breakage)
6. User enters correct password
7. Bug is created


There also is another bug about not detecting the correct app to file
crashers against; bug 352989:
http://bugzilla.gnome.org/show_bug.cgi?id=352989

This is basically due to eg nautilus-cd-burner and nautilus having
nautilus as Exec= line in the .desktop, making Bug-Buddy just take one
of those .desktop files. There should be some extra code to detect the
correct one. This is made more urgent as nautilus-cd-burner does not
have the correct info in the .desktop file (meaning a nautilus crasher
will not even be filled in other product -- they will be rejected).

Hopefully that one can be fixed before code freeze.

-- 
Regards,
Olav