Evolution string freeze break request



Hi, all.

As part of working on the fix for bug #349966 (1), Srinivasa Ragavan and
I have decided that a new gconf key needs to be added.  This would break
string freeze, so I'm requesting here, before anything gets committed.

Here's the background.  As part of the change that switched evolution
from using gnome_file_entry to using gtk_file_chooser, a bug was
introduced where, under some circumstances, a URI could be saved in the
gconf key /apps/evolution/mail/save_dir, which was later passed to a
non-URI accepting function.  The discussion around the fix for this
resulted in my producing a patch to convert all users of that key
(except one) to using only URI based file access, allowing remote access
over, say, sftp:// URIs.  Srinivasa and I agree that this is a very
desirable feature to have in 2.16, especially since the mixture of local
paths and URIs has caused problems in the past.

However, there's one piece of code in evolution that still uses
gnome_file_entry for it's dialogs, which won't take URIs.  This is the
code to add a specific alarm audio file to an alarm in the calendar.
This code was also using the /apps/evolution/mail/save_dir key, which we
consider to be a bug.  Adding an alarm file shouldn't change the
directory used to save attachments.  In addition, changing this to use
gtk_file_chooser was deemed to large a change for this late in the
release cycle.  It will occur in evo 2.9.

The solution to this is to add a new key for the alarm audio file
dialogs to use.  This key will be /apps/evolution/calendar/audio_dir.
The schema (2) added for this breaks string freeze.

If this freeze break is granted, I'd like to add another request to it:
the key /apps/evolution/mail/save_dir, which has existed for many
versions, currently has no schema.  I would like to add a schema (3) for
it, which would also break string freeze.

Daniel

(1) http://bugzilla.gnome.org/show_bug.cgi?id=349966

(2) Proposed schema for /apps/evolution/calendar/audio_dir
+    <schema>
+      <key>/schemas/apps/evolution/calendar/audio_dir</key>
+      <applyto>/apps/evolution/calendar/audio_dir</applyto>
+      <owner>evolution-calendar</owner>
+      <type>string</type>
+      <locale name="C">
+        <short>Save directory for alarm audio</short>
+         <long>
+           Directory for saving alarm audio files
+         </long>
+      </locale>
+    </schema>

(3) Proposed schema for /apps/evolution/mail/save_dir
+    <schema>
+      <key>/schemas/apps/evolution/mail/save_dir</key>
+      <applyto>/apps/evolution/mail/save_dir</applyto>
+      <owner>evolution-mail</owner>
+      <type>string</type>
+      <locale name="C">
+         <short>Save directory</short>
+         <long>
+           Directory for saving mail component files
+         </long>
+      </locale>
+    </schema>

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]