Re: Request for UI freeze break (gnome-panel)

["John (J5) Palmieri" <johnp redhat com>]

Looks good to me. Approval 2 of 2.

On Mon, 2006-08-07 at 12:36 +0200, Vincent Untz wrote:
> On lun, 2006-08-07 at 11:08 +0200, Frederic Crozat wrote:
> > Le lundi 07 ao�06 �3:10 +0200, Vincent Untz a �it :
> > > Hi all,
> > > 
> > > I have a (big :-)) patch to use a new dialog to edit launcher. This is
> > > basically bug 95331 [1]. Except that I won't commit the dialog to
> > > gnome-desktop, but to gnome-panel (since I'm not sure we want to have it
> > > in gnome-desktop and my current patch depends on some stuff in the panel
> > > code).
> > > 
> > > It's quite a huge improvement, so I'd really like to commit it :-)
> > > 
> > > Thanks,
> > > 
> > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=95331
> > 
> > This looks sane and a good improvement.
> > 
> > Approval 1 of 2.
> > 
> > BTW, there shouldn't be a Browse button for an URL ;)
> 
> Well, the current version does not talk about URL, but about Location.
> And it can be a local file, so it makes sense in this case :-)
> 
> Vincent
> 
--