Re: Code Freeze Break Request

[Elijah Newren <newren gmail com>]

Hi,

On 9/3/05, Rodney Dawes <dobey novell com> wrote:

Hi,

So, this is a request for a rather last minute breakage of the code
freeze, I know, but I think it's quite important to fix for 2.12,
and the change is minimal.

http://bugzilla.gnome.org/show_bug.cgi?id=313680

This bug is for a "change" that broke HIG compliance, though I've
made no changes to the UI of the capplet, since its introduction
around Gnome 2.6 . It seems, however, that something is going wrong
with GTK+ 2.8, and there is a race condition on how it deals with
the border width for the action area, getting set. The latest patch
attached to this bug, adds a little style property setting, so that
the issue with GTK+ 2.8 is worked around, and the dialog spacing
looks correct again.

Can I please commit this? Thanks.

It would make things look much better, but personally I'd prefer to avoid non-critical fixes at this point as there's almost no time to cleanup any fixes if they happen to have unexpected problems.  Also, it seems like lots of dialogs may have this problem and gtk+ may need to be fixed for this class of problems anyway[1].  However, since it is a really simple patch and I'm guessing it's unlikely to introduce problems, maybe others on the team will approve.

- Elijah

[1] By the way, have you filed a gtk+ bug about comment 16 in bug 313680 (I tried a quick search and didn't see anything)?