Re: Patch to xine-lib backend of Totem

["Murray Cumming" <murrayc murrayc com>]

> Le vendredi 02 septembre 2005 à 11:08 +0100, Bastien Nocera a écrit :
>> 2005-08-08  Bastien Nocera  <hadess hadess net>
>>
>>         * NEWS: upd
>>         * src/backend/bacon-video-widget-xine.c:
>>         (bacon_video_widget_realize), (bacon_video_widget_new):
>>         Only set the default vis plugin name if we don't already have
>> one
>>
>> 2005-08-08  Bastien Nocera  <hadess hadess net>
>>
>>         * src/backend/bacon-video-widget-xine.c:
>> (bacon_video_widget_init),
>>         (bacon_video_widget_realize), (bacon_video_widget_unrealize),
>>         (show_vfx_update), (bacon_video_widget_set_visuals):
>>         Create the visual effects plugins when needed, instead of on
>> startup,
>>         this should make startup slightly faster
>>
>> Those 2 changes broke setting and running visuals with the xine-lib
>> backend. Currently, running "totem <audio-only-file>" will get you no
>> visual effects, even though enabled, and changing visual plugins while
>> playing a video is also broken.
>>
>> Patch attached.
>
> As a reminder, totem is not using xine-lib backend by default but I
> asked Bastien to send the patch approval request :)
>
> Approval 1 of 2.

It doesn't seem worth breaking the build, but we can be fairly sure that
the code has zero effect on the default build, so 2 of 2.

Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com