Re: Request for approval

[Luis Villa <luis villa gmail com>]

They do more code review than we do :) 1 of 2.
Luis


On Fri, 04 Mar 2005 15:38:16 +0100, Rodrigo Moya <rodrigo novell com> wrote:
> Hi
> 
> This is a request for approval for a couple Evolution crashes.
> 
> Bug is http://bugzilla.ximian.com/show_bug.cgi?id=72835
> 
> It's already been approved by the Evolution team
> --
> Rodrigo Moya <rodrigo novell com>
> 
> 
> 
> ---------- Forwarded message ----------
> From: Rodrigo Moya <rodrigo novell com>
> To: Evolution Patches <evolution-patches lists ximian com>
> Date: Fri, 04 Mar 2005 12:22:18 +0100
> Subject: Re: [evolution-patches] patch for crash in alarm notify
> On Thu, 2005-03-03 at 20:18 +0100, Rodrigo Moya wrote:
> > On Thu, 2005-03-03 at 19:56 +0100, Rodrigo Moya wrote:
> > > On Mon, 2005-02-28 at 13:16 +0100, Rodrigo Moya wrote:
> > > > This removes use of g_assert and does a better management of the
> > > > midnight_refresh
> > >
> > > discard this one, this fix is now included in the attached patch, which
> > > also fixes #72835 (crash in alarm daemon)
> >
> > sorry, previous patch didn't fix all cases mentioned in the bug. Now
> > this new one should fix all of them.
> 
> a new version, with a missing line in
> alarm-notify-dialog.c#dialog_response_cb to call the callback also when
> 'Close' is selected. This was preventing the dialog to be closed.
> --
> Rodrigo Moya <rodrigo novell com>
> 
> 
> _______________________________________________
> release-team mailing list
> release-team gnome org
> http://mail.gnome.org/mailman/listinfo/release-team
> 
> 
> 
>