Re: UI Freeze Break for the Desktop Background capplet

[Vincent Untz <vuntz gnome org>]

Le lundi 15 ao�05 �6:53 -0400, Rodney Dawes a �it :
> > Whether or not it is a bugfix or a feature... well, I guess I'm
> > tempted to just let it slide and say 1 of 2. I assume you've tested
> > this diligently? I really don't want to hear people filing that their
> > background chooser is segfaulting :)
> 
> I've compiled it, and it doesn't crash. The code really isn't changing
> that much. It's basically moving a bunch of calls into a new method,
> and adding a check to make sure the key is writable. Though, now that
> I look at the code beyond things that would be obvious and not compile,
> I see a couple of issues, though nothing fatal. One line of code that
> does not need to be there (that I had already asked the patch author
> to remove), a small style issue, and a leak. All of these are simple
> to fix though, and I'll put up a patch that has those fixes tonight.

2 of 2, then.

Vincent

-- 
Les gens heureux ne sont pas press�