Re: [Planner Dev] "Nonstandard Days" and "Dominant tasks" - 5th patch - the end of the tunnel ? ; )

[Richard Hult <richard imendio com>]

Hi,

Thanks guys, this looks really nice :) Let's get it committed, maybe
after fixing the bug Kurt found?

/Richard

Matteo Nastasi skrev:
> On Tue, Mar 21, 2006 at 10:35:53PM -0500, Kurt Maute wrote:
>> On Tue, 2006-03-21 at 11:08 +0100, Matteo Nastasi wrote:
>>> Hi guys, attached the 5th revision of my patch.
>>>
>>> Your comments are wellcome.
>> I didn't want to torture you any longer with picky stylistic issues, so
>> I went ahead and made some adjustments in terms of spacing, and one
>> instance of omitted braces on a for statement.  Patch attached.
> I appreciate a lot. Molte grazie.
> 
>> I did notice something though, it appears when zooming out on a project
>> until the weekend nonworking time is no longer greyed out in the gantt
>> background.  Looks like the gantt bars white out during the weekend time
>> creating a striped look.  This is new behavior.
>>
>> http://www.maute.us/planner/images/WeekendStriping.png
> Sound like a bug. I investigate it, thank you.
> 
>>> ADDENDA: I think that I solve the vertical alignement problem of the 
>>> text at right of the tasks in gantt view, can you verify it ?
>> Looks like they're vertically centered now.  I don't see a bug report
>> for vertical alignment though - maybe I missed it.
> No bug report, was a "FIXME note" into the code.
> 
> Regards, Matteo.
> 

-- 
Imendio AB, http://www.imendio.com/