Re: [Planner Dev] Hours per day does not have to be an integer

[Richard Hult <richard imendio com>]

Henning Kulander wrote:
> Hi!

Hi,

> I've been playing around with Planner here, trying to use it for a
> project. When I adjusted the working-day to a standard Norwegian 7.5
> hours day, things started too look wrong. 

Yeah, we have a long-standing bug for this.

> I played around with the source of 0.12.1 and found that the problem is
> a combination of hardcoding 8 hours working day and the use of integers
> for hours_per_day. I made a patch which fixes this behaviour (attached).

Nice! Although I think it would be better to use the same unit as the 
rest of the code instead of hours (i.e. seconds), rather than having a 
float here.

We have also been loosly discussing exactly how to handle the conversion 
between the displayed value in days and the exact value. With your fix, 
it would depend on the exact calendar used by the particular resource, 
right? That's one of the solutions we've suggested, the other one was to 
have a project wide setting for how long a day should be. I'm still not 
sure which way is best. Any comments on that?

> In my testing I have not encountered any new bugs. One bug related to
> this I was not able to fix was the HTML export. I do not know anything
> about XSLT, so I was not able to fix this. From what I gathered, a
> variable containing the sum (in seconds) of the intervals
> in //project//calendar//overridden-day-type//interval needs to be
> calculated and used in the mrproj-duration template. 

Yeah, sounds like it's something like that.

Regards,
Richard

--
Imendio AB, http://www.imendio.com/