Re: [Planner Dev] Patch to fix Resource Usage menus and some of the odd display behaviors.

[Richard Hult <richard imendio com>]

On mån, 2004-05-03 at 06:01 +0100, lincoln phipps openmutual net wrote:
> The attached patch fixes..

Thanks!

> Edit menu in resource usage view is strange...
> http://bugzilla.gnome.org/show_bug.cgi?id=138149 as originally reported.

This does a whole lot more than fixing that bug. I don't want to add a
lot of functionality to the resource usage view for 0.12, and we really
need to clean it up before adding stuff otherwise it'll end up a total
nightmare.

Right now it has at least the following problems:

1. The coding style is a mess, indentation, whitespace, bad hacks etc.
We should fix this before adding stuff.

2. It contains LOTS of cut-and-paste code from the gantt chart, which is
error prone and bloated. We should fix this as well, before adding
stuff.

So, for now I've only commited a fix for the weird Edit menu with lots
of separators.

> Zoom to extremes possible on Resource Usage (TTable) view.
> http://bugzilla.gnome.org/show_bug.cgi?id=141116 (found during testing)

Good catch, this is also committed.

> Tree expansion state gets out of sync in Resource Usage v...
> http://bugzilla.gnome.org/show_bug.cgi?id=141117 (found during testing)

Hm, do I get it right when I think this patch makes all of the tree
collapse when you insert one task? This part has not been committed.

> Plus adds selections and multi-dialog support to the selections
> in the Resource Usage view.

This is really not 0.12 material, like I've said on the list before.

Please try and keep patches separate, even if they are in the same files
etc. It's as simple as keeping separate checked out versions of the
source, that usually works really well.

Thanks,
Richard

-- 
Imendio HB, http://www.imendio.com/