Re: [Planner Dev] [PATCH] HIGification/usability work

[Christian Neumair <chris gnome-de org>]

On Di, 2003-12-16 at 19:02 +0100, Richard Hult wrote:
> tis 2003-12-16 klockan 17.51 skrev Christian Neumair:
> > I know, glade patches are horrible - at least for reviewing individuals.
> > You may want to check out this one, though. It tries to clean up some of
> > planner's UI. Note that I plan to do more stuff, this is just the first
> > step :).
> 
> Thanks!
> 
> As you say, it sucks to review glade patches. So I applyied and tried
> the result and the overall look is very nice.
> 
> I have just a few questions:
> 
> The border_width of 5 for scrolled windows, is that a convention?
> 
> Likewise for dialogs (I imagine that the total padding including that
> from the children adds up to a HIGy amount?)
> 
> There are also a few other places where you've used a spacing of 5, I
> don't remember seeing that value anywhere in the HIG...
The tricky thing is that dialogs should have:
- border of 12 px
- 12 px between buttons and content widgets

default situation:
- GtkDialog custom border +=2 px (I)
- GtkActionArea custom border += 5 px (II)

pseudo-mathematical sulution:
(II) => content widget's border: 5px (alignment) (III)
(I), (II), (III) => additional border of GtkDialog: 5px 
(II), (III) => spacing of GtkDialog's vbox: 2 px

> wmclass/wmname was removed in at least one place, was that intentional
> and if so, why?
No, that wasn't intentional. Obviously some glade borkage.

regs,
 Chris