On Mon, 2005-10-17 at 11:44 +0100, John Rice wrote:
> Kinda sucks - and yes you are entirely correct that we could just
> remove the g_return_* calls from all static functions, but I'd have
> thought converting them into g_asserts was probably more consistent
> with the original authors intention - though could be wrong of
> course :)
I agree, all static uses of g_return_* should be replaced with g_asserts
or normal if() tests on sight, depending on what the intent of the
original check was.
Ross
--
Ross Burton mail: ross burtonini com
jabber: ross burtonini com
www: http://www.burtonini.com./
PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF
Attachment:
signature.asc
Description: This is a digitally signed message part