Re: scripts and paired chars revisited



On Sat, 2005-11-05 at 00:30 -0500, Matthias Clasen wrote:
> I have attached another version of the easy-scripts-and-paired-chars
> patch to http://bugzilla.gnome.org/show_bug.cgi?id=320666
> 
> It improves upon Federicos latest version in the following ways:
> 
> - make pango_script_for_unichar a simple wrapper around
>   pango_script_for_unichar_with_last_index()
> 
> - remove ranges below 0x2000 from pango-script-table.h
> 
> - make better use of the information contained in last_index
>   by using failed tests to reduce the range for binary search
> 
> - use the fact that all paired characters are Common to avoid
>   more get_pair_index() calls

Kick ass!  Thanks for the changes; I made a few cosmetic cleanups to
gen-easy-scripts-table and committed everything to Pango.

There's an updated plot attached to the bug report; it shows that this
patch is somewhat faster than Behdad's 3-level table :)  So Behdad buys
the beer this time.

  Federico




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]