RFC: patch iop-profiles.c

[Frank Rehberger <Frank Rehberger web de>]

Request for comments:

The following patch includes:
* iop-profiles.c (IOP_ObjectKey_dump): zero padding for 2 digit hex-codes
* iop-profiles.c (IOP_profile_dump): temporary char  buffer is free'd 

Best regards, Frank
Index: iop-profiles.c
===================================================================
RCS file: /cvs/gnome/ORBit2/src/orb/orb-core/iop-profiles.c,v
retrieving revision 1.43
diff -u -r1.43 iop-profiles.c
--- iop-profiles.c	30 May 2003 15:55:09 -0000	1.43
+++ iop-profiles.c	27 Jul 2003 23:08:34 -0000
@@ -38,7 +38,7 @@
 	GString *str = g_string_sized_new (objkey->_length * 2 + 4);
 
 	for (i = 0; i < objkey->_length; i++)
-		g_string_append_printf (str, "%2x", objkey->_buffer [i]);
+		g_string_append_printf (str, "%02x", objkey->_buffer [i]);
 
 	return g_string_free (str, FALSE);
 }
@@ -61,6 +61,7 @@
 		key = IOP_ObjectKey_dump (obj->object_key);
 		g_string_printf (str, "P-IIOP %s:0x%x '%s'",
 				 iiop->host, iiop->port, key);
+		g_free (key);
 		break;
 	}
 	
@@ -82,6 +83,8 @@
 		g_string_printf (str, "P-OS %s:0x%x '%s'",
 				 os->unix_sock_path, os->ipv6_port,
 				 key);
+
+		g_free (key);
 		break;
 	}
 	case IOP_TAG_MULTIPLE_COMPONENTS:
@@ -90,8 +93,6 @@
 		break;
 	}
 
-	g_free (key);
-	
 	return g_string_free (str, FALSE);
 }
 
@@ -358,6 +359,9 @@
 
 		if (strcmp (iiop1->host, iiop2->host))
 			return FALSE;
+
+		/* FIXME, also compare ssl ports */ 
+
 		break;
 	}