Re: [PATCH] ORBit memory alignment bug

[Michael Meeks <michael ximian com>]

Hi Hans,

On Thu, 2002-10-03 at 17:44, Hans Petter Jansson wrote:
> ORBit's giop-recv-buffers rely on malloc() returning 8-byte aligned
> memory. This is true for Linux/glibc/i386, but other allocators,
> particularly valgrind's, align to 4 bytes.

	It's an ok patch - I'd prefer not to add another 4+4 bytes per recv
buffer if possible though.

	Have you tried the --alignment=8 parameter to valgrind ? I imagine
that's what you want :-)

> The assertion that checks the alignment is wrong, which means that when
> the marshaler and demarshaler get memory blocks aligned to 4 and 8 bytes
> respectively

	We should assert fail if alignment is not to 8 bytes; if that's not
working - it needs fixing; we should also flag the valgrind argument in
that warning IMHO. 

	HTH,

		Michael.

-- 
 mmeeks@gnu.org  <><, Pseudo Engineer, itinerant idiot