Re: ORBit2 parallel install fixes



Hi Havoc,

On 13 Sep 2001, Havoc Pennington wrote:

> Sure, I'll attach my current orbit2 and bonobo-activation diffs.
>
> I also have patches against the whole dependency stack above those
> though, and against gnome-libs 1.0, and the whole deal. ;-) So it's
> kind of a mess until we get it all in CVS.

	So I've looked at the patch and there's a few comments I'd like
to make...

	* We shouldn't be including IDL.h anywhere in ORBit2's sources
	apart from orbit-idl. I've fixed this in CVS.

	* The namespacing of the headers to ${includedir}/orbit-2.0 is
	unneccesary, I think. ORBit-0.5.x headers reside in
	${includedir}/orb and ORBit2's in ${includedir}/orbit.

	* I'm curious about the change to ORBit-CosNaming-2.0.pc
	although I'd certainly defer to your wisdom on that ;)

	* I wonder can we kill the ORBIT2=1 define?

	* Can we try an solve your poa IDL_DIR problem seperately?

> > Another point: should orbit-config-2 be removed altogether? Since
> > gnome-2 should be a (almost) pkgconfig world, leaving unpatched
> > orbit-config-2 can be misleading. IIRC glib and gtk+ is following
> > this path.
>
> Elliot dislikes pkg-config for some reason he hasn't explained to me,
> so ORBit is keeping the -config scripts for now.

	I personally think that the -config scripts should go - but I
also don't know the reason for Elliot's dislike of pkg-config.

Cheers,
Mark.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]