[PATCH] orbit-config.in + gcc-3.0 (re-post)

[Murray Cumming <Murray_Cumming BetaResearch de>]

I don't see any response to Daniel's posts? Can I feel free to commit
this to orbit cvs?

Daniel Elstner wrote:
> 
> Hello,
> 
> sorry for posting this again, but I haven't got any reply
> wether the patch will be accepted.  Unfortunately I'm not
> sending out patches every day, so it could easily be
> possible that I made some stupid beginners mistake like
> not following some patch guideline or similar rules.
> 
> I apologize for bothering you again now, but we need this
> patch to be in place to close a bug report for the GNOME--
> project (which won't compile without it when using GCC 3.0).
> 
> Thanks in anticipation,
> --Daniel
> 
> >>>> original post follows: >>>>
> 
> Hi,
> 
> here's a patch for orbit-config.in adding a test wether
> $includedir = /usr/include, and omitting -I$includedir if
> true.  The -I/usr/include would otherwise prevent almost
> every C++ program from compiling with gcc-3.0.
> 
> If you're interested in the details why -I/usr/include
> is a really bad idea, here are some pointers:
> 
> http://gcc.gnu.org/ml/gcc/2001-06/msg00948.html
> http://www.geocrawler.com/lists/3/SourceForge/1110/75/6325952/
> 
> Regards,
> --Daniel
> 
> (I'm not subscribed, so please CC to me. Thanks.)
> 
> 
> --- orbit-config.in.orig        Mon Aug 20 17:28:34 2001
> +++ orbit-config.in     Mon Aug 20 17:35:05 2001
> @@ -88,7 +88,9 @@
>  
>      client|server)
>         the_libs="$the_libs -L$libdir -lORBit -lIIOP -lORBitutil `glib-config --libs` @LIBS@ -lm"
> -       the_flags="$the_flags `glib-config --cflags` -I$includedir "
> +       the_flags="$the_flags `glib-config --cflags` "
> +       test "x$includedir" = "x/usr/include" \
> +           || the_flags="$the_flags -I$includedir "
>         ;;
>  
>     --use-service=*)