Re: orbit-config.in patch

[Ross Golder <ross golder org>]

I've got a patch for orbit-config.in to make it use pkg-config.

Apparently, orbit-config.in is ./configured to orbit-config, and then
copied to orbit2-config by the Makefile. What's all that about? :)

So, as my program uses /usr/share/aclocal/ORBit2.m4, which rather than
use pkg-config directly (shouldn't it?) calls orbit2-config, and asks
for the --cflags. Only, the --cflags it returns are wrong (probably from
old version 1), but it uses pkg-config to garner the glib-2.0 --cflags.
I've patched it to use pkg-config --cflags ORBit-2.0 (which includes the
glib-2.0 --cflags).

But, I'm thinking that the correct approach would be to have ORBit2.m4
use pkg-config directly, bypassing the need for an orbit2-config. Am I
off the mark here?

And another query - I guess I'm doing the right thing posting all these
patches here, but what happens next (or... which of the following
potential outcomes are good, bad, likely or unlikely)?

- One of the lead ORBit developers jumps up and says 'that's fine, go
ahead and commit it'.
- One of the lead ORBit developers jumps up and says 'that's crap, this
is what's wrong with it'.
- One of the lead ORBit developers commits it, and says 'that's fine,
committed'.
- One of the lead ORBit developers commits it, and keeps it to himself.
- I get bored waiting for a response, commit it, it's ok, everyone's
happy.
- I get bored waiting for a response, commit it, it's bad, a few people
are unhappy, someone reverses it.
- Nothing. My patches get consigned to the depths of a mailman archive.

Thanks in advance,

--
Ross
Index: orbit-config.in
===================================================================
RCS file: /cvs/gnome/ORBit2/orbit-config.in,v
retrieving revision 1.10
diff -u -r1.10 orbit-config.in
--- orbit-config.in	2001/06/14 06:41:48	1.10
+++ orbit-config.in	2001/10/13 17:21:38
@@ -29,8 +29,8 @@
 
 Known values for TARGET are:
 
-    client		(calls glib-config)
-    server		(calls glib-config)
+    client		(calls pkg-config)
+    server		(calls pkg-config)
 EOF
 
     exit $1
@@ -42,8 +42,8 @@
 
 cflags=false
 libs=false
-the_libs="$the_libs -L$libdir -lORBit `${PKG_CONFIG} --libs glib-2.0` @LIBS@ -lm"
-the_flags="$the_flags `${PKG_CONFIG} --cflags glib-2.0` -I$includedir -DORBIT2=1"
+the_libs="$the_libs `${PKG_CONFIG} --libs ORBit-2.0` @LIBS@ -lm"
+the_flags="$the_flags `${PKG_CONFIG} --cflags ORBit-2.0`"
 
 while test $# -gt 0; do
     case "$1" in