A strange patch that breaks python ...



Hi there,

	When I released ORBit I had no idea of the changes that were
lurking in there due to the lack of ChangeLog - and it took me 5-10
minutes to actualy find who made this change; and I'm now none the
wiser as to why:

http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvs/gnome&subdir=ORBit/src/orb&command=DIFF_FRAMESET&file=poa.c&rev2=1.62.4.4&rev1=1.62.4.3

	The commit message says "Bunch of bug fixes from bugzilla" can
someone elaborate ? which bugs ? who hit this ? why did it need fixing
like this.

	It seems to be screwing over the python bindings.

Index: src/orb/poa.c
===================================================================
RCS file: /cvs/gnome/ORBit/src/orb/poa.c,v
retrieving revision 1.62.4.3
retrieving revision 1.62.4.4
diff -u -p -u -r1.62.4.3 -r1.62.4.4
--- src/orb/poa.c	2001/03/09 09:25:08	1.62.4.3
+++ src/orb/poa.c	2001/09/11 22:25:39	1.62.4.4
@@ -827,6 +827,9 @@ PortableServer_POA_deactivate_object(Por
 				CORBA_FALSE,
 				CORBA_FALSE,
 				ev);
+	} else {
+	  PortableServer_ServantBase *serv = oldobj->servant;
+	  serv->_private = NULL;
 	}
 
 	CORBA_free(oldobj->object_id);


	In ORBit2 it seems we use pobj->servant to be equivilant to
whether the object is active or not. Is that incorrect ? it seems in
ORBit stable we don't.

	In short - what is going on ?

	Regards,

		Michael.

-- 
 mmeeks@gnu.org  <><, Pseudo Engineer, itinerant idiot




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]