Re: some fixes in ORBit2

[Dmitry Yusupov <dmy7 yahoo com>]

On Wed, Jan 10, 2001 at 12:51:52PM -0500, Elliot Lee wrote:
> On Tue, 9 Jan 2001, Dmitry Yusupov wrote:
> 
> > I found some bugs during hacking.
> > First one got marshaling problem and G_BREAKPOINT arose for
> > all ORBit2/test examples for me. I'm not sure. May be this one wrong.
> > But this work fine for me at least.
> >
> > Index: src/orb/GIOP/giop-recv-buffer.c
> > ===================================================================
> > RCS file: /cvs/gnome/ORBit2/src/orb/GIOP/giop-recv-buffer.c,v
> > retrieving revision 1.15
> > diff -u -r1.15 giop-recv-buffer.c
> > --- src/orb/GIOP/giop-recv-buffer.c	2000/11/13 18:35:19	1.15
> > +++ src/orb/GIOP/giop-recv-buffer.c	2001/01/09 07:25:58
> > @@ -566,8 +566,8 @@
> >    if(giop_msg_conversion_needed(buf))
> >      len = GUINT32_SWAP_LE_BE(len);
> >    buf->cur += 4;
> > -  if((buf->cur + len) > buf->end
> > -     || (buf->cur + len) < buf->cur)
> > +  if(/*(buf->cur + len) > buf->end
> > +     ||*/ (buf->cur + len) < buf->cur)
> >      {
> >        G_BREAKPOINT();
> >        return NULL;
> 
> G_BREAKPOINT() was probably a debugging thing - I think that should just
> be 'return NULL' for normal usage.
> 
> However, that case should definitely be kicking in - there is an error in
> the incoming message or the code if this happens.

I not went out from ORBit2 frame project. I made experiments 
with echo-server and echo-client from ORBit2/test directory.

> 
> I will leave the G_BREAKPOINT() there for now, until we can figure out why
> this error is happening...

I tried return NULL from this place this function but the problem arose again.
Very odd things happend. May be these things only my environment specific...
I shall try gdb it.

-- 
Best regards,
Dmitry