Re: Patch to add libnotify support to nm-applet

Rodney Dawes wrote:
> Ah. Looks like g-p-m could use a little updating then. If you pass in
> the last argument to notify_notification_new (), then the code will just
> automatically get the info needed for the x/y hints from that widget.
> Here's an updated patch that does this, rather than adding all the extra
> duplicate code into nm itself.

Yes, this looks much better now! One last issue: Could you store the
reference to the NotifyNotification somewhere so that you have to create
it only once and not on each event. I would also suggest to move
notify_init somewhere into the constructor of NMWirelessApplet so that
it has to be called only on the initial setup.


Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]