Re: nm-applet patch

[Christopher Aillon <caillon redhat com>]

On 10/19/2005 12:53 PM, Jeroen Zwartepoorte wrote:
> The icon theme i'm using (graphite, inherits from gnome icon theme;
> see gnome-look.org) supplies a menu sized icon for this stock item.
> Afaik there is no other GTK authentication/lock stock item.
>
> Jeroen
>
> On 10/19/05, Christopher Aillon <caillon redhat com> wrote:
>   
> > On 10/19/2005 12:12 PM, Robert Love wrote:
> >     
> > > On Tue, 2005-10-18 at 15:52 +0200, Jeroen Zwartepoorte wrote:
> > >
> > >       
> > > > Here's a tiny patch that changes the stock icon used for nm-applet.
> > > > The icon theme i'm using (gnome icon-theme inherited) has a menu-sized
> > > > icon for GTK_STOCK_DIALOG_AUTHENTICATION but not for
> > > > "gnome-lockscreen".
> > > >
> > > >         
> > > Hey, I finally went through this and verified it is the right thing to
> > > do, so I committed the patch.  Thanks.
> > >
> > > Chris - I am presupposing that this also looks right on Fedora.  We
> > > really should be using a stock icon define.
> > >
> > >       Robert Love
> > >
> > >       
> > Actually, this patch is wrong.  GTK_STOCK_DIALOG_AUTHENTICATION is only
> > for dialogs and will cause the icon to be scaled down (not ideal).  I
> > asked mclasen about this, and he says the better solution for now is to
> > include the gnome-lockscreen icon in our source.
Your theme is broken then.  DIALOG in the name means dialog.  Not menu.  
The default themes will not have a menu sized icon so it will not look 
as nice.  Don't optimize for a non-standard theme that most people will 
not have.