Re: [patch] redo tray icon.

[Dan Williams <dcbw redhat com>]

On Thu, 2005-07-07 at 16:43 -0400, Robert Love wrote:
> So...the NetworkManager tray icon is a bit weird, as it packs a top menu
> bar into the tray.  Not sure why that route was chosen, unless someone
> wanted to pack a container into an event box, which you cannot do.  The
> problem with packing the menu bar into the tray is that many themes draw
> gradients or other details under menu bars.  Thus, the icon looks funny.
> Also, the packed menu bar takes up a lot of room, leaving a weird couple
> pixels of spacing on either side of the icon.
> 
> Instead, "applet->pixmap" is packed into "applet->event_box", which is 
> packed into "applet->icon_box", which is packed into the top of the
> tray.  Looks and acts more natural.
> 
> Patch by Aaron Bockover.
> 
> May I apply?

Ok, here's the 1 thing I don't like about it.  But I'm not particularly
attached to this 1 thing.

The old applet has the menu item highlight when you drop it down, at
least under ClearLooks.  With the patch, nothing happens to the icon
when you click on the menu.  It doesn't act like a menu in a menu bar.
I'd prefer it if the patch kept the current behavior of highlighting the
menu item in the panel when the menu is dropped down.

The patch correctly removes the all-the-time highlight underneath the
icon though (again, at least under ClearLooks).  I'm thinking about the
same behavior the volume applet has here, that works like I expect it
to.

Dan