Re: 1.286 nm_deactivate_device bug

[Bill Moss <bmoss clemson edu>]

I have patched for debugging. Yes, the value of the renew timeout id or 
tag is 2.

The output

Feb 20 10:17:09 localhost NetworkManager: renew timeout is 2
Feb 20 10:17:09 localhost NetworkManager: g_source_remove_gboolean is 0
Feb 20 10:17:09 localhost NetworkManager: rebind timeout is 3

is produced by the patch

--- NetworkManagerDevice.c_orig 2005-02-20 11:35:00.042126136 -0500
+++ NetworkManagerDevice.c 2005-02-20 10:00:51.000000000 -0500
@@ -2527,11 +2527,14 @@
return (TRUE);

/* Remove any DHCP timeouts we may have had running */
+syslog (LOG_INFO, "renew timeout is %d\n", dev->renew_timeout);
if (dev->renew_timeout > 0)
{
- g_source_remove (dev->renew_timeout);
+/* g_source_remove (dev->renew_timeout); */
+syslog (LOG_INFO, "g_source_remove_gboolean is %d\n", g_source_remove 
(dev->renew_timeout));
dev->renew_timeout = 0;
}
+syslog (LOG_INFO, "rebind timeout is %d\n", dev->rebind_timeout);
if (dev->rebind_timeout > 0)
{
g_source_remove (dev->rebind_timeout);


Dan Williams wrote:

> At this time, is dev->renew_timeout > 0?
>
> On Sun, 20 Feb 2005, Bill Moss wrote:
>
>  
>
> > Scenario: connect wireless, switch to wired. At the t1 time, NM tries to 
> > renew the wireless address. The wireless device should have been 
> > deactivated by the function nm_device_deactivate.
> >
> > In function nm_device_deactivate, the call to
> >
> > g_source_remove (dev->renew_timeout)
> >
> > is returning a 0 which means it fails and so renewal events continue to 
> > occur.
> >
> > --
> > Bill Moss
> > Professor, Mathematical Sciences
> > Clemson University
> >
> > _______________________________________________
> > NetworkManager-list mailing list
> > NetworkManager-list gnome org
> > http://mail.gnome.org/mailman/listinfo/networkmanager-list
> >
> >    
>
>  

--
Bill Moss
Professor, Mathematical Sciences
Clemson University