Re: [PATCH] speed up stock icon registration (was: Improving Nautilus startup time)
- From: Christian Neumair <chris gnome-de org>
- To: Alexander Larsson <alexl redhat com>
- Cc: Federico Mena Quintero <federico ximian com>, nautilus-list gnome org, performance-list gnome org
- Subject: Re: [PATCH] speed up stock icon registration (was: Improving Nautilus startup time)
- Date: Mon, 20 Mar 2006 16:49:12 +0100
Am Montag, den 20.03.2006, 14:20 +0100 schrieb Alexander Larsson:
> On Thu, 2006-03-09 at 12:17 +0100, Christian Neumair
> > The attached patch ensures that we don't hardcode any pixels/icon sizes
> > and don't lookup any stock icons during icon registration, but just add
> > all the stock icon names we need to the factory. Measuring with a GTimer
> > I could reduce the icon registration to rougly 1/4 of the former time,
> > mostly because the gtk_icon_theme_lookup_icon calls are quite expensive.
> > I don't know whether it buys us much to delay the icon size lookups
> > until they're actually needed, but the Nautilus startup feels
> > significantly faster with the patch applied.
>
> Looks good. Please commit.
Done.
--
Christian Neumair <chris gnome-de org>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
