Re: [PATCH] Don't set r/o permissions when copying from r/o locations



On Fri, 2006-03-10 at 18:45 +0100, Christian Neumair wrote:
> Am Freitag, den 10.03.2006, 10:37 +0100 schrieb Alexander Larsson:
> > On Thu, 2006-03-09 at 22:39 +0100, Christian Neumair wrote:
> > > The attached patch ensures that CDs are copied with r/w permissions by
> > > passing GNOME_VFS_XFER_TARGET_DEFAULT_PERMS to the Xfer operation if one
> > > of the source URIs is on a CD-ROM, or another read-only location. This
> > > has to wait until after the code freeze, and fixes bug 167102 [1].
> > > 
> > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=167102#
> > 
> > Take a look at gnome_vfs_volume_monitor_get_volume_for_path(). It'll
> > help your patch a lot.
> 
> Whoho, thanks!
> 
> Proposed nautilus, gnome-vfs and hal patches attached. CCing David.
> Notably the HAL semantics allow us to use new API without depending on a
> nev version :).

Looks good to commit, with the fix davidz wrote about.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lonely amnesiac shaman with a passion for fast cars. She's a 
sharp-shooting out-of-work safe cracker with a birthmark shaped like Liberty's 
torch. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]