Re: [PATCH] Don't set r/o permissions when copying from r/o locations



On Fri, 2006-03-10 at 18:45 +0100, Christian Neumair wrote:
> Proposed nautilus, gnome-vfs and hal patches attached. CCing David.

HAL patch looks good; committed this on HEAD of HAL CVS with the change
that we always set volume.is_mounted_read_only to FALSE when creating
the hal device object (function hotplug_event_begin_add_blockdev). It
will be in the HAL release (which is 0.5.8). Thanks!

Notably it works when I insert a SD card that is "locked", see

 http://en.wikipedia.org/wiki/Secure_Digital_card

for details. At least the kernel knows this fact at device insertion
time, maybe HAL should know too and export a property, say,
volume.is_read_only. Maybe it's not useful though; it's probably not
interesting before we mount it.

> Notably the HAL semantics allow us to use new API without depending on a
> nev version :).

Ah nice.. At some point we'll fix this up to use the libhal-storage API
you introduced and save ourselves a round trip to the haldaemon :-)

Cheers,
David





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]