Re: [PATCH] Icon view RTL layout

[Alexander Larsson <alexl redhat com>]

On Wed, 2006-03-01 at 20:28 +0100, Christian Neumair wrote:
> Am Dienstag, den 28.02.2006, 12:02 +0100 schrieb Christian Neumair:
> > Am Dienstag, den 28.02.2006, 10:59 +0100 schrieb Alexander Larsson:
> > > On Tue, 2006-02-28 at 10:49 +0100, Christian Neumair wrote:
> > > > Am Dienstag, den 28.02.2006, 10:43 +0100 schrieb Alexander Larsson:
> > > > > Maybe this just should wait until after 2.14. We're only one week from
> > > > > total code freeze. 
> > > > 
> > > > At the moment Nautilus is totally unusable for people with RTL layouts
> > > > with text besides icon. I think the situation can't get much worse.
> > > 
> > > It can definitely get worse. For instance it might be unusable for
> > > people in both RTL and LTR layouts. Or it might randomly crash.
> > > 
> > > I'm not saying you patch causes this, I'm just saying, this is why we
> > > have freezes, and do as little as possible at the end. We have *no* new
> > > release before the final 2.14 tarball now, so changes will get zero
> > > testing. We already have a major regression in 2.13.92:
> > > http://bugzilla.gnome.org/show_bug.cgi?id=332784
> > > Lets make sure we don't have any more...
> > > 
> > > I'm sure you think this is boring, and RTL people won't like it, but
> > > release management is not done to piss people off, its very important to
> > > not fuck up the release for everyone.
> > 
> > I see...so maybe we can get the attached patch in which at least fixes
> > the icon text alignment for RTL environments (i.e. all filenames can be
> > read)? This is neccessary because we use the layout both for measurement
> > and for drawing. The offset modification slightly prettifies the
> > alignment.
> 
> Yeah, and of course it *had* to break. The attached patch ensures that
> the layout code is completely identical with text below icon, which
> hopefully qualifies it for 2.14.

It makes us layout all text twice in text-besides-icon mode (set_width
will invalidate the layout that pango_layout_get_pixel_size caused).
Laying out the text is among the most expensive things we do per-file,
so i think this will cause a performance regression-

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a gun-slinging neurotic stage actor with a passion for fast cars. She's a 
cold-hearted winged femme fatale from beyond the grave. They fight crime!