Re: [PATCH] Try to open parent folder when viewed folder is deleted



On Sun, 2006-07-02 at 10:40 +0200, Christian Neumair wrote:
> The attached patch ensures that we try to display an existing parent
> folder when the viewed file is deleted [1] in Navigation mode.
> It also removes two obsolete undefined functions.
> 
> I must admit that sync I/O might not be the best idea, maybe we should
> make the affected window desensitive and install an async callback for
> the file info.
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=336724

This looks good to me. It does some sync i.o, but only to parents of a
folder we showed, so its unlikely we get any auth dialogs, and this is
not a very common occurance.

As to the NULL case, we should fallback to showing $HOME.
Please commit with that addition.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a maverick ninja grifter haunted by memories of 'Nam. She's a beautiful 
green-skinned single mother who believes she is the reincarnation of an 
ancient Egyptian queen. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]